Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vapp description and add vapp.Rename #372

Merged
merged 8 commits into from
Apr 30, 2021

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Apr 28, 2021

  • Added parameter description to method vdc.ComposeRawVapp (This method is used in terraform-provider-vcd to create a vApp.)
  • Added methods vapp.Rename, vapp.UpdateDescription, vapp.UpdateNameDescription. This make it possible to update the vApp's name and description in Terraform.

Giuseppe Maxia added 2 commits April 28, 2021 12:39
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder requested a review from Didainius April 28, 2021 15:07
@dataclouder dataclouder assigned lvirbalas and unassigned lvirbalas Apr 28, 2021
@dataclouder dataclouder requested a review from lvirbalas April 28, 2021 15:07
@dataclouder dataclouder self-assigned this Apr 28, 2021
@dataclouder dataclouder marked this pull request as ready for review April 28, 2021 15:08
Signed-off-by: Giuseppe Maxia <[email protected]>
Giuseppe Maxia added 2 commits April 29, 2021 10:24
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Giuseppe Maxia added 2 commits April 29, 2021 11:20
Adding an explicit description, so that we can check its value

Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants